Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better environment handling for SDKs, removing almost-duplicate method. #1320

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Better environment handling for SDKs, removing almost-duplicate method. #1320

merged 1 commit into from
Jan 23, 2024

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Jan 23, 2024

  • Removing PackageAnalyzer.create as it has very little benefit over ToolEnvironment.create.
  • Consolidated environment handling in ToolEnvironment, added config home dir option.

@isoos isoos requested review from jonasfj and sigurdm January 23, 2024 10:14
@isoos isoos merged commit 57e8fe3 into dart-lang:master Jan 23, 2024
4 of 5 checks passed
@isoos isoos deleted the config-home branch January 23, 2024 12:03
@isoos isoos mentioned this pull request Jan 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigurdm sigurdm sigurdm approved these changes

@jonasfj jonasfj Awaiting requested review from jonasfj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isoos @sigurdm